[feature-volumes] Use PluginGetter instead of Cluster CSIConfig #3016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Converts the manager portion of the CSI code to use the Docker `PluginGetter` interface, instead of the CSIConfig object. Converts the agent to get its plugins from the PluginGetter, rather than getting them from the manager. Also removes the dispatcher sending updates about CSI node plugins. Removes various CSI plugin configuration fields from the API protocol buffers. Since we'll be using the plugingetter, these are no longer necessary. When publishing volumes, uses a propagated mount location, and resolves that location when getting the volume. Signed-off-by: Drew Erny <[email protected]>
dperny
force-pushed
the
feature-volumes-managed-plugin
branch
from
afb7028 to
d0176b4
Compare
Both the agent and manager of swarmkit's CSI components need a fake PluginGetter object for testing. This splits that common fake into its own object in the testutils package. Signed-off-by: Drew Erny <[email protected]>
Removing the CSIConfig object from the cluster requires changes to other tests. Signed-off-by: Drew Erny <[email protected]>
dperny
force-pushed
the
feature-volumes-managed-plugin
branch
from
524613e to
cca3615
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts the manager portion of the CSI code to use the Docker
PluginGetterinterface, instead of the CSIConfig object.Converts the agent to get its plugins from the PluginGetter, rather than getting them from the manager. Also removes the dispatcher sending updates about CSI node plugins.
Removes various CSI plugin configuration fields from the API protocol buffers. Since we'll be using the plugingetter, these are no longer necessary.
When publishing volumes, uses a propagated mount location, and resolves that location when getting the volume.