Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature-volumes] Fix template tests #3023

Merged

Conversation

dperny
Copy link
Collaborator

@dperny dperny commented Jul 27, 2021

The signature for the agent.NewDependencyManager function has changed because of CSI support. Adds an empty FakePluginGetter to this constructor so that the tests compile.

The signature for the `agent.NewDependencyManager` function has changed
because of CSI support. Adds an empty FakePluginGetter to this
constructor so that the tests compile.

Signed-off-by: Drew Erny <[email protected]>
@codecov
Copy link

codecov bot commented Jul 27, 2021

Codecov Report

Merging #3023 (fb51b39) into feature-volumes (ddec5e5) will increase coverage by 1.66%.
The diff coverage is 59.60%.

@@                 Coverage Diff                 @@
##           feature-volumes    #3023      +/-   ##
===================================================
+ Coverage            60.67%   62.34%   +1.66%     
===================================================
  Files                  155      155              
  Lines                21732    24521    +2789     
===================================================
+ Hits                 13186    15287    +2101     
- Misses                7002     7638     +636     
- Partials              1544     1596      +52     

@dperny dperny merged commit 24aaa54 into moby:feature-volumes Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant