You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason will be displayed to describe this comment to others. Learn more.
Confused about this. Did this commit actually fix the problem (and if so, how?). BrowserStdout doesn't seem to make any use of a level option, but rather a label option.
37193a4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confused about this. Did this commit actually fix the problem (and if so, how?).
BrowserStdout doesn't seem to make any use of a
level
option, but rather alabel
option.@skeggse, @mattflix, @boneskull ping concerning #2095!
37193a4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@plroebuck True this should be
label
notlevel
37193a4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Huh. I can't recall what I was working on, nor whether I even had the time to test this change. Please do open a PR to fix this!
37193a4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skeggse @plroebuck done! check #3477
37193a4
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@skeggse, how did you (intend to) test this fix? We should ensure it's really gone with #3477.
Can't believe no one noticed (commented) that the Mocha-4.0 release didn't fix the problem given its release notes.