🚀 Feature: Use process.browser to detect environment

[limdauto]

I think it's generally accepted that to check whether an environment is node or browser, we should type check window, instead of document, because sometimes document is mocked for testing purpose.

[jbnicolai]

I'd rather use process.browser, see https://github.com/mochajs/mocha/blob/master/lib/utils.js#L690

If you'd like to open a PR for this, please do!

[boneskull]

process.browser please. I tend to stub window when unit testing my browserified code on the server.

[ndhoule]

Yeah, process.browser is the way to go. #1727 changed a bunch of these env checks to use process.browser, but I pretty much did the bare minimum to get it working so I'm sure there are more.

[stale]

I am a bot that watches issues for inactivity.
This issue hasn't had any recent activity, and I'm labeling it stale. In 14 days, if there are no further comments or activity, I will close this issue.
Thanks for contributing to Mocha!

[anmuel]

I'd like to contribute here :)
Was the mentioned TODO the only place to look at? (I doubt it)

[boneskull]

@anmuel Thanks. You could grep around for window or document and see if there's anything else that needs addressing, but that's about all I know of right now.