-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
We shouldn't rely on the existence of "module.paths" (Meteor) #2505
Comments
In this case, I think we can |
Hi, is there any movement around this? I get an error in the following snippet: if (!process.browser) {
var cwd = process.cwd();
module.paths.push(cwd, path$2.join(cwd, 'node_modules')); // <= here
}
|
Does the serverless environment not support As this is marked |
I take a guess: could it be empty because there's no Would bypassing that lines of code break the framework? I could help if pointed to the right direction |
According to CommonJS specs, the
paths
property is optional. Depending on its existence, e.g.https://github.com/mochajs/mocha/blob/master/lib/mocha.js#L28
may cause unnecessary runtime errors, for example:
benjamn/install#9
We should probably test against the property existence before modifying
module.paths
.The text was updated successfully, but these errors were encountered: