-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Node v12 in test matrix instead v11 #3891
Conversation
AppVeyor has a problem with Node v12. I will dig it. |
boneskull/node-environment-flags should also be revised. |
@outsideris I just realised it's not necessary to update "boneskull/node-environment-flags".:
=> native implementation: |
Travis also fails with:
see PR #3900 |
Signed-off-by: Outsider <[email protected]>
Rebase and try this again. |
I already rebased this. However, there is a weired error at |
Until pre-installed Node-12 image available, switched from `Install-Product` to slower `Update-NodeJSInstallation`.
Added `libpango` to attempt to get `canvas` to build on Node-12 for browser tests.
Try again, this time adding _all_ external libraries from its [Ubuntu installation instructions](https://github.com/Automattic/node-canvas/wiki/Installation:-Ubuntu-and-other-Debian-based-systems).
I think we should go with #3919, ty. |
Today Node v12 has been released. So, it's a new current version of Node.
Test mocha with Node v12 instead of v11.