use "basic_wait" as the default scheduler #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- the "default" scheduler refers to the Argobots default, which causes idle execution streams to spin looking for new work units - the "basic_wait" scheduler is the one that pairs with the "fifo_wait" pool type that we are using by default and will suspend until work is available
|
Whoops. I need to check/fix the other unit tests. Will push corrections in a bit. |
Codecov Report
@@ Coverage Diff @@
## main #249 +/- ##
==========================================
+ Coverage 54.27% 54.40% +0.12%
==========================================
Files 65 65
Lines 8867 8865 -2
Branches 1164 1164
==========================================
+ Hits 4813 4823 +10
+ Misses 3359 3345 -14
- Partials 695 697 +2
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Fixed. |
|
Approved! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #248.
Once this is validated and merged then I'll update the scheduling unit test to fail if CPU usage is too high.