Allow equal signs (=) in values #21
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mockturtl
pushed a commit
that referenced
this pull request
Oct 29, 2019
mockturtl
approved these changes
Oct 29, 2019
|
Looks great, thanks! |
|
Merged in #22. |
|
Shipped. |
|
Thanks for the fast response! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @mockturtl,
This PR fixes a bug that prevents the parser from correctly parsing values that contain equal signs (
=).The problem is caused by performing a string split on every occurrence of the equal sign character, which causes the unintended side effect of also splitting the value of the variable.
Example
A base64 encoded string will often end with an equal sign due to padding. For example, the string
"foo"is encoded as"Zm9vCg==", but incorrectly parsed by this library:Note the missing
==signs. The fix contained in this PR allows the correct parsing of the variable asZm9vCg==.Thanks, I hope you get a chance to review and merge this PR soon.