-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FS-149] New blobs upload API #2608
Open
dflemstr
wants to merge
13
commits into
main
Choose a base branch
from
dflemstr/new-blobs-upload-api
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dflemstr
force-pushed
the
dflemstr/new-blobs-upload-api
branch
from
December 4, 2024 14:45
2b8c984
to
6c6b211
Compare
freider
reviewed
Dec 4, 2024
dflemstr
force-pushed
the
dflemstr/new-blobs-upload-api
branch
from
December 4, 2024 15:48
c0fcaf9
to
55309a1
Compare
erikbern
reviewed
Dec 4, 2024
) -> None: | ||
): | ||
def ceildiv(a, b): | ||
return -(a // -b) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤯
We're taking another pass at refining the API internally, so I will leave this PR hanging for a bit while we settle on our next API iteration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A work-in-progress PR to start using the new Blobs service for client-side file uploads. Both the API and implementation details are subject to change.