Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FS-149] New blobs upload API #2608

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

Conversation

dflemstr
Copy link
Contributor

@dflemstr dflemstr commented Dec 4, 2024

A work-in-progress PR to start using the new Blobs service for client-side file uploads. Both the API and implementation details are subject to change.

  • Client+Server: this change is compatible with old servers (NOTE: not backwards compatible with old servers)
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

@dflemstr dflemstr changed the title Dflemstr/new blobs upload api [FS-149] New blobs upload API Dec 4, 2024
@dflemstr dflemstr force-pushed the dflemstr/new-blobs-upload-api branch from 2b8c984 to 6c6b211 Compare December 4, 2024 14:45
protoc_plugin/plugin.py Outdated Show resolved Hide resolved
@dflemstr dflemstr force-pushed the dflemstr/new-blobs-upload-api branch from c0fcaf9 to 55309a1 Compare December 4, 2024 15:48
@dflemstr dflemstr marked this pull request as draft December 4, 2024 15:50
@dflemstr dflemstr marked this pull request as ready for review December 4, 2024 17:21
) -> None:
):
def ceildiv(a, b):
return -(a // -b)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤯

@dflemstr
Copy link
Contributor Author

dflemstr commented Dec 5, 2024

We're taking another pass at refining the API internally, so I will leave this PR hanging for a bit while we settle on our next API iteration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants