Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds pending deprecations for Mount.from_* methods #2683

Merged
merged 10 commits into from
Jan 10, 2025

Conversation

freider
Copy link
Contributor

@freider freider commented Dec 18, 2024

Will nudge users toward new replacements ahead of real deprecation with client 1.0

Describe your changes

  • Provide Linear issue reference (e.g. MOD-1234) if available.
Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Changelog

@mwaskom
Copy link
Contributor

mwaskom commented Dec 18, 2024

Does making these pending=True have any practical implications for users? They seem equally visible.

@freider freider requested a review from mwaskom January 8, 2025 14:23
@freider
Copy link
Contributor Author

freider commented Jan 9, 2025

@prbot approve

Copy link

@modal-pr-review-automation modal-pr-review-automation bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved 👍. @mwaskom will follow-up review this.

Copy link
Contributor

@kramstrom kramstrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@kramstrom
Copy link
Contributor

Does making these pending=True have any practical implications for users? They seem equally visible.

It's only to not have them raised as errors in the tests right? Until we remove them and don't need the tests anymore

@freider freider merged commit 83650fa into main Jan 10, 2025
22 checks passed
@freider freider deleted the freider/mount-constructor-deprecations branch January 10, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants