Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

volume put: upload without sha256 hash #2723

Draft
wants to merge 1 commit into
base: dano/mount-put-file-response-sha256-hex
Choose a base branch
from

Conversation

danielnorberg
Copy link
Contributor

Let the backend return the resulting sha256 hash instead of computing it up front.

Requires #2722 and corresponding internal change to make sha256_hex optional in the MountPutFile handler.

Describe your changes

  • Provide Linear issue reference (e.g. MOD-1234) if available.
Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Changelog

@danielnorberg danielnorberg force-pushed the dano/volume-omit-sha256-in-mount-put-file branch 3 times, most recently from ad6426b to ba23c03 Compare January 4, 2025 02:44
Let the backend return the resulting sha256 hash instead of computing it up front.

Requires #2722 and corresponding internal change to make sha256_hex optional in the MountPutFile handler.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant