Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add modal volume rename and modal.Volume.rename #2737

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

mwaskom
Copy link
Contributor

@mwaskom mwaskom commented Jan 8, 2025

Depends on #2736 and https://github.com/modal-labs/modal/pull/18674

Backward/forward compatibility checks

Check these boxes or delete any item (or this section) if not relevant for this PR.

  • Client+Server: this change is compatible with old servers
  • Client forward compatibility: this change ensures client can accept data intended for later versions of itself

Note on protobuf: protobuf message changes in one place may have impact to
multiple entities (client, server, worker, database). See points above.


Changelog

  • Modal Volumes can now be renamed via the CLI (modal volume rename) or SDK (modal.Volume.rename).

@mwaskom mwaskom requested a review from erikbern January 8, 2025 19:55
Copy link
Contributor

@erikbern erikbern left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great!

@mwaskom mwaskom force-pushed the michael/2025-01-08-volume-rename branch from ab9c1d7 to 570cc68 Compare January 8, 2025 21:43
@mwaskom mwaskom merged commit 9743e02 into main Jan 8, 2025
22 checks passed
@mwaskom mwaskom deleted the michael/2025-01-08-volume-rename branch January 8, 2025 22:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants