Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade upload-artifact and download-artifact actions #3492

Closed
zhassan-aws opened this issue Sep 4, 2024 · 0 comments · Fixed by #3745
Closed

Upgrade upload-artifact and download-artifact actions #3492

zhassan-aws opened this issue Sep 4, 2024 · 0 comments · Fixed by #3745
Labels
[C] Internal Tracks some internal work. I.e.: Users should not be affected. [I] CI / Infrastructure Work done to CI, tests and infrastructure. T-High Priority Tag issues that have high priority

Comments

@zhassan-aws
Copy link
Contributor

Proposed change:
Upgrade the versions of the actions/upload-artifact and actions/download-artifact actions to v4.

Motivation:
The version we're currently using for the actions/upload-artifact and actions/download-artifact actions (v3) is scheduled for deprecation on Nov 30, 2024.

This upgrade was attempted in #3487, but it failed because v4 of the action runs on node20, which doesn't work with Ubuntu 18.04.

We recently had to work around this issue with v3 through setting:

ACTIONS_ALLOW_USE_UNSECURE_NODE_VERSION: true

See #3322 for details.

To upgrade the versions, we'll either have to find a workaround that works with Ubuntu 18.04 or drop support for Ubuntu 18.04 and AL2.

@zhassan-aws zhassan-aws added T-High Priority Tag issues that have high priority [C] Internal Tracks some internal work. I.e.: Users should not be affected. [I] CI / Infrastructure Work done to CI, tests and infrastructure. labels Sep 4, 2024
github-merge-queue bot pushed a commit that referenced this issue Dec 2, 2024
Resolves #3492

By submitting this pull request, I confirm that my contribution is made
under the terms of the Apache 2.0 and MIT licenses.

---------

Co-authored-by: Zyad Hassan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[C] Internal Tracks some internal work. I.e.: Users should not be affected. [I] CI / Infrastructure Work done to CI, tests and infrastructure. T-High Priority Tag issues that have high priority
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant