Disable SIMD intrinsics #1143
Merged
Disable SIMD intrinsics #1143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks reasonable to me, Adrian. Do we have a ticket to track re-enabling these intrinsics at some point? |
danielsn
approved these changes
May 3, 2022
| fargs, | ||
| p, | ||
| cbmc_ret_ty, | ||
| n |
There was a problem hiding this comment.
I had to add _ to all non-used variables, functions or macros because it would introduce a warning otherwise (the unstable_codegen macro causes them to not be used). I want to avoid "using" them because the changes would be untested. Of course, the compiler will let us know what variables have to be corrected when we restore them.
We didn't, but made one: #1148 . Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Disables all SIMD intrinsics, which were not considered during the general intrinsics audit. The main concern is with these intrinsics is that overflow checks do not seem to be introduced for some of them.
Call-outs:
Testing:
How is this change tested? Converts 4 tests to "fixme".
Is this a refactor change? No.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.