Use num::BigInt instead of i128 in constants, as constants can be of arbitrary size. #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markrtuttle
approved these changes
May 21, 2021
| [[package]] | ||
| name = "num-integer" | ||
| version = "0.1.43" | ||
| version = "0.1.44" |
There was a problem hiding this comment.
Is this bump necessary for num-bitint 0.4.0? Will this make future upstreams trickier?
There was a problem hiding this comment.
Good question. Realistically, I think we can accept any version. We can always change this if there is a problem when doing upstreaming.
celinval
pushed a commit
to celinval/kani-dev
that referenced
this pull request
Nov 16, 2021
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Describe RMC's current behavior and how your code changes that behavior. If there are no issues this PR is resolving, explain why this change is necessary.
Resolved issues:
Resolves #140
Call-outs:
Testing:
How is this change tested? Added new regression test
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.