[Blocked on #1435] Support proptest arbitrary generation for bool and tuple #1467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 30 commits
July 1, 2022 15:30
TOOD: API implementation, BODY1
7 tasks
celinval
requested changes
Aug 9, 2022
There was a problem hiding this comment.
Copying my comment from #1435
I don't think we should add the proptest code in our repository. We should probably do one of the following:
- Refactor the changes so we can extend proptest instead of forking from it.
- If we do need to fork proptest, we should create a separate repository with the fork. We should then add a submodule here to this fork.
Feel free to ping me offline if you want to discuss this further or if you have any suggestions.
| @@ -80,10 +82,18 @@ impl KaniSession { | |||
| }); | |||
| } | |||
|
|
|||
| let mut symtabs = glob(&outdir.join("*.symtab.json"))?; | |||
| let mut metadata = glob(&outdir.join("*.kani-metadata.json"))?; | |||
| if std::env::var("IS_KANI_PROPTEST").is_ok() { | |||
There was a problem hiding this comment.
Shouldn't this be a runtime option?
|
Closing pull request in favor of merging to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Added support for arbitrary generation trait, and implemented it for booleans and tuples.
Resolved issues:
Resolves: #1363, PR 2/3
Call-outs:
Testing:
How is this change tested? tests/cargo-kani/proptest/src/arbitrary_boolean.rs
Is this a refactor change? No
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.