Restore simd_extract and simd_insert intrinsics
#1942
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tedinski
approved these changes
Nov 29, 2022
Comment on lines
+36
to
+37
| let m = unsafe { simd_insert(y, 0, 1_i64) }; | ||
| let n = unsafe { simd_insert(y, 1, 5_i64) }; |
There was a problem hiding this comment.
Do we know if this limitation (needing that cast) will cause problems in how it gets used in real code?
There was a problem hiding this comment.
Hey @tedinski, sorry for the late reply.
Just wanted to make clear that this is just mimicking rustc's current behavior. Some SIMD intrinsics require additional type-checking done by the backend, as in here. This would prevent us from accepting that, in principle, cannot be compiled with rustc (this was the case for this test).
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Restores the SIMD "construction" intrinsics
simd_extractandsimd_insert.As in #1853, we must perform some type-checks that depend on the back-end. These type-checking errors are now caught and we include a couple of test cases to ensure that they remain that way.
Resolved issues:
Towards #1148
Testing:
How is this change tested? Existing regression. Adds two new tests, converts a "fixme".
Is this a refactor change? Not completely, the main novelty here are the type-checks.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.