Partial support for Generator type #486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avanhatt
force-pushed
the
generators
branch
from
a593c53 to
980517e
Compare
tedinski
approved these changes
Sep 16, 2021
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 22, 2022
Partial support for Generator type
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 25, 2022
Partial support for Generator type
tedinski
pushed a commit
to tedinski/rmc
that referenced
this pull request
Apr 26, 2022
Partial support for Generator type
tedinski
pushed a commit
that referenced
this pull request
Apr 27, 2022
Partial support for Generator type
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Rust added a new Generator type to support coroutines. This patch lets us codegen code that has the Generator type somewhere, but does not use it in paths that are being verified. This helps unblock crates that depend on the popular Tokio crate. Full support for Generator tracked in #416.
Resolved issues:
Resolves #459.
Call-outs:
Generatortype is a global codegen item, but it does not have a function signature, so we need to make the function signature on our context object optional.Testing:
New unit test.
Not really.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.