-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NonZero (clamp) Proof #200
Conversation
Co-authored-by: Michael Tautschnig <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of having a module for each function, can you move all of these harnesses inside of mod verify?
Done in NonZero (rotate_left & rotate_right) Proof #202 |
@@ -2265,3 +2265,77 @@ mod verify { | |||
nonzero_check!(u128, core::num::NonZeroU128, nonzero_check_new_unchecked_for_u128); | |||
nonzero_check!(usize, core::num::NonZeroUsize, nonzero_check_new_unchecked_for_usize); | |||
} | |||
|
|||
#[cfg(kani)] | |||
mod macro_nonzero_check_clamp { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please merge this into the verify
module as you did in #202?
Closing because this work got incorporated into #202 |
Working on #71 (Safety of NonZero)
We are looking for feedback on our proof for clamp.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 and MIT licenses.