Allow to check out branches #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsp-ant
requested changes
Dec 3, 2024
src/git/tests/test_server.py
Outdated
Comment on lines
1
to
24
| import pytest | ||
| from pathlib import Path | ||
| import git | ||
| from mcp_server_git.server import git_checkout | ||
|
|
||
| def test_git_checkout_existing_branch(tmp_path: Path): | ||
| # Setup test repo | ||
| repo = git.Repo.init(tmp_path) | ||
| Path(tmp_path / "test.txt").write_text("test") | ||
| repo.index.add(["test.txt"]) | ||
| repo.index.commit("initial commit") | ||
|
|
||
| # Create and test branch | ||
| repo.git.branch("test-branch") | ||
| result = git_checkout(repo, "test-branch") | ||
|
|
||
| assert "Switched to branch 'test-branch'" in result | ||
| assert repo.active_branch.name == "test-branch" | ||
|
|
||
| def test_git_checkout_nonexistent_branch(tmp_path: Path): | ||
| repo = git.Repo.init(tmp_path) | ||
|
|
||
| with pytest.raises(git.GitCommandError): | ||
| git_checkout(repo, "nonexistent-branch") |
There was a problem hiding this comment.
I am not sure we should add this test. It feels straight forward enough.
If we do add tests, we should use a proper fixture:
@pytest.fixture
def test_repository():
# Setup
temp_path = Path("temp_test_repo")
temp_path.mkdir(exist_ok=True)
# Initialize your repository here
# ...
yield temp_path
# Cleanup
shutil.rmtree(temp_path)
def test_git_checkout_existing_branch(test_repository):
...There was a problem hiding this comment.
@dsp-ant I think I've addressed your concern? Let me know what you think.
|
Overall this looks good. There are some changes I'd love to see to the test file. We either use a fixture or delete the tests. |
mikegehard
force-pushed
the
feature/git-checkout-command
branch
2 times, most recently
from
91039e3 to
cc4e29e
Compare
The git server currently lacks branch switching capabilities, limiting both LLMs and developers. This adds branch checkout so LLMs can help developers add new functionality in a new feature branch.
mikegehard
force-pushed
the
feature/git-checkout-command
branch
from
cc4e29e to
98e78c3
Compare
laith-abood
pushed a commit
to laith-abood/mcp-claude
that referenced
this pull request
Jan 13, 2025
…it-checkout-command Allow to check out branches
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The git server currently lacks branch switching capabilities, limiting both LLMs and developers. This adds branch checkout so LLMs can help developers add new functionality in a new feature branch.
Server Details
Motivation and Context
See #147
How Has This Been Tested?
Tested via the Claude macOS app.
Breaking Changes
No
Types of changes
Checklist