-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Restrictions and more examples for the Include annotation #3452
Restrictions and more examples for the Include annotation #3452
Conversation
Co-authored-by: Hans Olsson <[email protected]>
Co-authored-by: Hans Olsson <[email protected]>
When we add so many variants it might be best to also include the case of having a prototype directly in the included C-code. |
…notation To make sense, I needed to put all semantics related to the annotation in the same place.
I tried to do this, but in order to make explain why one would like to do so, I found it necessary to have all semantics for the Regarding prototype vs function declaration, I agree that we should go for the standard terminology used in C. Should we do it as part of this PR? |
Ok, but see comment about the latest addition.
Better to have it later, and separately as it involves other lines as well. |
…es.h A replacement will be proposed in the form of a separate PR.
Removed Draft state as this seems to have converged enough for a language group decision. |
To me this makes sense, but since it adds new behavior I think it is good to get input from the group. Use emojis to vote - (left-bottom, closes day before phone meeting):
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems ok.
Fixes #3451.
Opening in Draft state as the idea is to have a discussion here about how to resolve #3451.