Fix Clocks/FMI3.xml and validate in CI #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KarlWernersson
requested changes
Apr 19, 2021
Clocks/FMI3.xml
Outdated
| <InitialUnknown valueReference="2001"/> | ||
| <InitialUnknown valueReference="2002"/> | ||
| <InitialUnknown valueReference="2003"/> | ||
| <InitialUnknown valueReference="1005"/> |
There was a problem hiding this comment.
<InitialUnknown valueReference="1005"/> should not be there.
Clocks should not be in initalUnknonws.
| <Clock name="inClock3" valueReference="1003" start="0" causality="input" interval="countdown" priority="2"/> | ||
| <Clock name="outClock" valueReference="1005" causality="output" interval="triggered" priority="2" clocks="1001 1002 1003"/> | ||
| <Int32 name="inClock1Ticks" valueReference="2001" causality="output" clocks="1001"/> | ||
| <Int32 name="inClock2Ticks" valueReference="2002" causality="output" clocks="1002"/> | ||
| <Int32 name="inClock3Ticks" valueReference="2003" causality="output"/> |
There was a problem hiding this comment.
Is it intentional that inClock3Ticks does not belong to a clock?
| <Clock name="outClock" valueReference="1005" causality="output" interval="triggered" priority="2"/> | ||
| <Int32 name="inClock1Ticks" valueReference="2001" causality="output"/> | ||
| <Int32 name="inClock2Ticks" valueReference="2002" causality="output"/> | ||
| <Clock name="inClock1" valueReference="1001" start="0" causality="input" interval="constant" intervalDecimal="1.0" priority="0"/> |
There was a problem hiding this comment.
I think start values for clocks are pointless and confusing. But it is correct according to the current standard.
I will open a sperate ticket about it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.