fix: replace navigations to data:, with about:blank (#1993)

modernweb-dev · Jul 18, 2022 · 8a81317 · 8a81317
1 parent 3f671e7
commit 8a81317
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 3 deletions.
diff --git a/.changeset/tough-bikes-study.md b/.changeset/tough-bikes-study.md
@@ -0,0 +1,6 @@
+---
+'@web/test-runner-selenium': patch
+'@web/test-runner-webdriver': patch
+---
+
+Navigations to blank pages now use `about:blank` instead of `data:,`.
diff --git a/packages/test-runner-selenium/src/IFrameManager.ts b/packages/test-runner-selenium/src/IFrameManager.ts
@@ -139,7 +139,7 @@ export class IFrameManager {
       }
 
       // set src after retreiving values to avoid the iframe from navigating away
-      iframe.src = "data:,";
+      iframe.src = "about:blank";
       return { testCoverage: testCoverage };
     `);
 

diff --git a/packages/test-runner-webdriver/src/IFrameManager.ts b/packages/test-runner-webdriver/src/IFrameManager.ts
@@ -134,7 +134,7 @@ export class IFrameManager {
       iframe.addEventListener('load', loaded);
       iframe.addEventListener('error', loaded);
       // set src after retrieving values to avoid the iframe from navigating away
-      iframe.src = "data:,";
+      iframe.src = "about:blank";
     `);
 
     if (!validateBrowserResult(returnValue)) {

diff --git a/packages/test-runner-webdriver/src/SessionManager.ts b/packages/test-runner-webdriver/src/SessionManager.ts
@@ -73,7 +73,7 @@ export class SessionManager {
     const { testCoverage } = returnValue;
 
     // navigate to an empty page to kill any running code on the page
-    await this.driver.navigateTo('data:,');
+    await this.driver.navigateTo('about:blank');
 
     this.urlMap.delete(id);