feat(storybook-builder): bundle preview assets

modernweb-dev · Mar 19, 2024 · f29dbce · f29dbce
1 parent e611720
commit f29dbce
Show file tree

Hide file tree

Showing 4 changed files with 11 additions and 5 deletions.
diff --git a/.changeset/tricky-sloths-retire.md b/.changeset/tricky-sloths-retire.md
@@ -0,0 +1,5 @@
+---
+'@web/storybook-builder': patch
+---
+
+bundle preview assets
diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/storybook-builder/package.json b/packages/storybook-builder/package.json
@@ -56,7 +56,7 @@
     "@web/dev-server": "^0.4.0",
     "@web/dev-server-core": "^0.7.0",
     "@web/dev-server-rollup": "^0.6.1",
-    "@web/rollup-plugin-html": "^2.1.2",
+    "@web/rollup-plugin-html": "^2.3.0",
     "browser-assert": "^1.2.1",
     "es-module-lexer": "^1.2.1",
     "esbuild": "^0.19.5",

diff --git a/packages/storybook-builder/src/index.ts b/packages/storybook-builder/src/index.ts
@@ -142,8 +142,9 @@ export const build: WdsBuilder['build'] = async ({ startTime, options }) => {
     plugins: [
       rollupPluginHTML({
         input: { html: await generateIframeHtml(options), name: 'iframe.html' },
-        // default assets behavior of the plugin breaks, sb-common-assets are shared between manager and preview and copied separately
-        extractAssets: false,
+        extractAssets: true,
+        bundleAssetsFromCss: true,
+        externalAssets: 'sb-common-assets/**',
       }),
       rollupPluginNodeResolve(),
       rollupPluginPrebundleModules(env),