Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: Broken links in Modin Usage Examples page #7335

Closed
3 tasks done
MortalHappiness opened this issue Jul 3, 2024 · 3 comments · Fixed by #7336
Closed
3 tasks done

BUG: Broken links in Modin Usage Examples page #7335

MortalHappiness opened this issue Jul 3, 2024 · 3 comments · Fixed by #7336
Labels
bug 🦗 Something isn't working documentation 📜 Updates and issues with the documentation

Comments

@MortalHappiness
Copy link
Contributor

MortalHappiness commented Jul 3, 2024 •
edited
Loading

Modin version checks

  • I have checked that this issue has not already been reported.

  • I have confirmed this bug exists on the latest released version of Modin.

  • I have confirmed this bug exists on the main branch of Modin. (In order to do this you can follow this guide.)

Reproducible Example

N/A

Issue Description

This page has many borken links. For example,

modin/docs/usage_guide/examples/index.rst

Line 19 in 759d548

- Exercise 5: Setting up Modin in a Cluster Environment [`Source PandasOnRay <https://github.com/modin-project/modin/blob/main/examples/tutorial/jupyter/execution/pandas_on_ray/cluster/exercise_5.ipynb>`__]

Expected Behavior

No borken links.

Error Logs

No response

Installed Versions

Latest version of doc
@MortalHappiness MortalHappiness added bug 🦗 Something isn't working Triage 🩹 Issues that need triage labels Jul 3, 2024
@YarShev YarShev added documentation 📜 Updates and issues with the documentation and removed Triage 🩹 Issues that need triage labels Jul 3, 2024
@MortalHappiness MortalHappiness changed the title BUG: Documentation broken links BUG: Broken links in Modin Usage Examples page Jul 3, 2024
@YarShev
Copy link
Collaborator

YarShev commented Jul 3, 2024

Hi @MortalHappiness, thanks for posting this issue. @Retribution98, can you take a look at the broken links? IIRC, you were the last person who updated the pages for Modin on Ray in a cluster.

MortalHappiness added a commit to MortalHappiness/modin that referenced this issue Jul 3, 2024
@MortalHappiness
DOCS-modin-project#7335: Fix borken links in Modin Usage Examples page
8201afe 
Signed-off-by: Chi-Sheng Liu <[email protected]>
@MortalHappiness MortalHappiness mentioned this issue Jul 3, 2024
Merged
7 tasks
@MortalHappiness
Copy link
Contributor Author

@YarShev I opened a PR here.

#7336

@YarShev
Copy link
Collaborator

YarShev commented Jul 3, 2024

Oh, I see, thanks!

YarShev pushed a commit that referenced this issue Jul 3, 2024
@MortalHappiness
DOCS-#7335: Fix borken links in Modin Usage Examples page (#7336)
4e7afa7 
Signed-off-by: Chi-Sheng Liu <[email protected]>
arunjose696 pushed a commit to arunjose696/modin that referenced this issue Jul 11, 2024
@MortalHappiness @arunjose696
DOCS-modin-project#7335: Fix borken links in Modin Usage Examples page (
aa25287 
modin-project#7336)

Signed-off-by: Chi-Sheng Liu <[email protected]>
arunjose696 pushed a commit to arunjose696/modin that referenced this issue Jul 11, 2024
@MortalHappiness @arunjose696
DOCS-modin-project#7335: Fix borken links in Modin Usage Examples page (
8cd1452 
modin-project#7336)

Signed-off-by: Chi-Sheng Liu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug 🦗 Something isn't working documentation 📜 Updates and issues with the documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

DOCS-#7335: Fix borken links in Modin Usage Examples page MortalHappiness/modin
2 participants
@YarShev @MortalHappiness