FIX-#3342: Update pandas to 1.3.2 #3343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3343 +/- ##
===========================================
- Coverage 85.26% 28.29% -56.97%
===========================================
Files 150 144 -6
Lines 15839 15409 -430
===========================================
- Hits 13505 4360 -9145
- Misses 2334 11049 +8715
Continue to review full report at Codecov.
|
|
|
|
dchigarev
reviewed
Aug 17, 2021
| @@ -221,19 +221,7 @@ def _shift(data, periods, freq, axis, fill_value, is_set_nan_rows=True): | |||
| return result | |||
|
|
|||
| if freq is None and axis == 1 and self._axis == 0: | |||
| # 'by' columns should not be taken into account | |||
There was a problem hiding this comment.
removing workaround for pandas-dev/pandas#42401 bug since it was fixed in 1.3.2.
Now the removed case is handled naturally
anmyachev
force-pushed
the
dev/yigoshev-issue3342
branch
from
c5f3c84 to
d3006e1
Compare
YarShev
commented
Aug 18, 2021
anmyachev
force-pushed
the
dev/yigoshev-issue3342
branch
from
faa2ccf to
cea8735
Compare
|
The problem with OmniSci dependencies has gone after I removed Environment differences |
|
@dchigarev, what do you think what choice would be more appropriate between removing strict channel priority and pinning packages to concrete versions? |
anmyachev
force-pushed
the
dev/yigoshev-issue3342
branch
from
8154df6 to
6eafeeb
Compare
YarShev
force-pushed
the
dev/yigoshev-issue3342
branch
from
6eafeeb to
ec7aa9c
Compare
Signed-off-by: Igoshev, Yaroslav <[email protected]>
Signed-off-by: Dmitry Chigarev <[email protected]>
Signed-off-by: Myachev <[email protected]>
Signed-off-by: Myachev <[email protected]>
Signed-off-by: Myachev <[email protected]>
Signed-off-by: Myachev <[email protected]>
Signed-off-by: Myachev <[email protected]>
Signed-off-by: Myachev <[email protected]>
Co-authored-by: Yaroslav Igoshev <[email protected]> Signed-off-by: Myachev <[email protected]>
Signed-off-by: Dmitry Chigarev <[email protected]>
Signed-off-by: Dmitry Chigarev <[email protected]>
Signed-off-by: Dmitry Chigarev <[email protected]>
…ption Signed-off-by: Myachev <[email protected]>
anmyachev
force-pushed
the
dev/yigoshev-issue3342
branch
from
ec7aa9c to
89b41e8
Compare
@YarShev In a short-term perspective removing "strict" priority could work, but in a long term we should figure out why OmniSci env isn't working with the deps from conda-forge |
@dchigarev , I am okay with this. @maksimbo1 , can you take a look at this issue to fix it in near future? |
|
Waiting on approval from @modin-project/modin-omnisci |
ienkovich
approved these changes
Aug 19, 2021
|
@YarShev can we merge this since it got all of the required approvals? |
|
@dchigarev , yes, we can. |
Okay, I'll dig into it. Looks like we "forget" some deps. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Igoshev, Yaroslav [email protected]
What do these changes do?
flake8 modinblack --check modingit commit -sdocs/developer/architecture.rstis up-to-date