Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#5206: pin mypy<0.990 #5207

Merged
merged 1 commit into from
Nov 8, 2022
Merged

FIX-#5206: pin mypy<0.990 #5207

merged 1 commit into from
Nov 8, 2022

Conversation

dchigarev
Copy link
Collaborator

@dchigarev dchigarev commented Nov 8, 2022 •
edited
Loading

Signed-off-by: Dmitry Chigarev [email protected]

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves [CI] The latest mypy fails on current master #5206
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@dchigarev dchigarev changed the title DEPS-#5206: pin mypy<0.990 FIX-#5206: pin mypy<0.990 Nov 8, 2022
@dchigarev dchigarev marked this pull request as ready for review November 8, 2022 10:06
@dchigarev dchigarev requested a review from a team as a code owner November 8, 2022 10:06
pyrito
pyrito approved these changes Nov 8, 2022
View reviewed changes
Copy link
Collaborator

@pyrito pyrito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @dchigarev

@dchigarev
Copy link
Collaborator Author

The ray jobs seems to be failing due to new ray release (#5208)

@mvashishtha mvashishtha merged commit 54c41ab into modin-project:master Nov 8, 2022
@dchigarev dchigarev mentioned this pull request Nov 8, 2022
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvashishtha mvashishtha mvashishtha approved these changes

@pyrito pyrito pyrito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CI] The latest mypy fails on current master
3 participants
@dchigarev @pyrito @mvashishtha