Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TEST-#5219: relax matplotlib and coverage pins #5216

Merged
merged 1 commit into from
Nov 14, 2022

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Nov 14, 2022

Signed-off-by: Myachev [email protected]

What do these changes do?

Trying to make the same changes as in #4365.

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves TEST: matplotlib and coverage packages used in Modin environment are too old  #5219
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev changed the title relax matplotlib and coverage pins TEST: relax matplotlib and coverage pins Nov 14, 2022
@anmyachev anmyachev changed the title TEST: relax matplotlib and coverage pins TEST-#0000: relax matplotlib and coverage pins Nov 14, 2022
@anmyachev anmyachev changed the title TEST-#0000: relax matplotlib and coverage pins TEST-#5219: relax matplotlib and coverage pins Nov 14, 2022
@anmyachev anmyachev marked this pull request as ready for review November 14, 2022 16:45
@anmyachev anmyachev requested a review from a team as a code owner November 14, 2022 16:45
@dchigarev dchigarev merged commit 573c716 into modin-project:master Nov 14, 2022
@anmyachev anmyachev deleted the relax-some-pins branch November 14, 2022 18:04
@mvashishtha
Copy link
Collaborator

Thanks @anmyachev , I appreciate the effort to get us towards resolving all the issues in #5208 (comment) :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TEST: matplotlib and coverage packages used in Modin environment are too old
4 participants