Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#5208: support ray==2.1.0 #5283

Merged
merged 37 commits into from
Dec 2, 2022
Merged

FIX-#5208: support ray==2.1.0 #5283

merged 37 commits into from
Dec 2, 2022

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented Nov 29, 2022 •
edited
Loading

Signed-off-by: Myachev [email protected]

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves Modin fails on a simple code snippet with ray==2.1.0 in development environment #5208
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev mentioned this pull request Nov 29, 2022
Merged
7 tasks
@anmyachev
FIX-modin-project#5208: try to unpin ray
b542c0c 
Signed-off-by: Myachev <[email protected]>
@anmyachev
relax rpyc pin
3e08e42 
Signed-off-by: Myachev <[email protected]>
@anmyachev
Revert "relax rpyc pin"
2504819 
This reverts commit a3e253e.
@anmyachev
try to unpin redis
5cfc4e1 
Signed-off-by: Myachev <[email protected]>
@anmyachev
add pin for grpcio
6cbf459 
Signed-off-by: Myachev <[email protected]>
@anmyachev
Revert "try to unpin redis"
01fc113 
This reverts commit e2cf8ad.
@anmyachev
remove upper bound for redis
062e55b 
Signed-off-by: Myachev <[email protected]>
@anmyachev
Revert "remove upper bound for redis"
1320c46 
This reverts commit 1a0a26c.
@anmyachev
update minimal version of ray
41fea21 
Signed-off-by: Myachev <[email protected]>
@anmyachev
try another way
60aeafc 
Signed-off-by: Myachev <[email protected]>
@anmyachev
use ray-default
9da1a3d 
Signed-off-by: Myachev <[email protected]>
@anmyachev
remove redis
c2d167b 
Signed-off-by: Myachev <[email protected]>
@anmyachev
Revert "remove redis"
352d96e 
This reverts commit 30add60.
@anmyachev
move xgboost to conda deps
8077024 
Signed-off-by: Myachev <[email protected]>
@anmyachev
fixes
8ff76b5 
Signed-off-by: Myachev <[email protected]>
@anmyachev
use conda instead of pip where possible
8767cf6 
Signed-off-by: Myachev <[email protected]>
@anmyachev
fix connectorx that missed on windows
4d0c6b3 
Signed-off-by: Myachev <[email protected]>
@anmyachev
expicit try of usge ray-default==2.1.0
37d02e5 
Signed-off-by: Myachev <[email protected]>
@anmyachev
try pin protobuf
5d69740 
Signed-off-by: Myachev <[email protected]>
@anmyachev
fixes
f0ee565 
Signed-off-by: Myachev <[email protected]>
@anmyachev
try to unpin ray
31c08ae 
Signed-off-by: Myachev <[email protected]>
@anmyachev
try to ban bad grpcio version
7551066 
Signed-off-by: Myachev <[email protected]>
@anmyachev
try to fix wrong version of libprotobuf for grpcio
d6e1320 
Signed-off-by: Myachev <[email protected]>
@anmyachev
just experiment
ccf3d5f 
Signed-off-by: Myachev <[email protected]>
@anmyachev
fix
c745d59 
Signed-off-by: Myachev <[email protected]>
@anmyachev anmyachev changed the title TEST-#0000: try to unpin ray FIX-#5208: support ray==2.1.0 Dec 1, 2022
@anmyachev anmyachev changed the title FIX-#5208: support ray==2.1.0 FIX-#5208: support ray==2.1.0 Dec 1, 2022
@anmyachev
Copy link
Collaborator Author

Blocked by #5284

@anmyachev anmyachev marked this pull request as ready for review December 2, 2022 00:05
@anmyachev anmyachev requested a review from a team as a code owner December 2, 2022 00:05
@anmyachev anmyachev added Blocked ❌ A pull request that is blocked Ready for review labels Dec 2, 2022
@YarShev YarShev removed the Blocked ❌ A pull request that is blocked label Dec 2, 2022
@YarShev YarShev merged commit f1f3a62 into modin-project:master Dec 2, 2022
@anmyachev anmyachev deleted the issue4208-2 branch December 2, 2022 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

Assignees
No one assigned
Labels
Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Modin fails on a simple code snippet with ray==2.1.0 in development environment
2 participants
@anmyachev @YarShev