-
Notifications
You must be signed in to change notification settings - Fork 655
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FIX-#3371: Remove pandas patch level pin #6211
FIX-#3371: Remove pandas patch level pin #6211
Conversation
Signed-off-by: mvashishtha <[email protected]>
64bf46d
to
35374b6
Compare
setup.py
Outdated
@@ -47,7 +47,7 @@ def make_distribution(self): | |||
long_description=long_description, | |||
long_description_content_type="text/markdown", | |||
install_requires=[ | |||
"pandas==2.0.2", | |||
"pandas>1,<2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Imagine a case when the user has pandas=1.3.5 and python 3.7. Then he wants to install modin. However, Modin only supports python>=3.8. Maybe we should remove pandas patch level pin starting 2.0?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
users on pandas 1.3.5 and python 3.7 can't use the latest version of modin anyway because modin now requires python >= 3.8. I think this is a separate issue. What do you suggest that we change?
I suspect that even importing the latest modin code on python 3.7 would break because we make so many assumptions about what we can import from pandas. That was why backwards compatibility with python 3.6 was so much work. We should only consider backwards compatibility with python 3.7 if we know of a desire for it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes now are fine by me.
Co-authored-by: Anatoly Myachev <[email protected]>
Signed-off-by: mvashishtha <[email protected]>
…vashishtha/modin into 3371/fix/remove-pandas-patch-level-pin
@YarShev @anmyachev ready for merge |
Do note that this change is potentially opening a can of worms for us because we use some internal pandas things (be them functions, classes or variables), for which pandas is free to change or even remove those without breaking SemVer logic (as they're not public API). But then, we can always pin version again if such thing happens... |
What do these changes do?
Remove pandas patch level pin as we agreed here.
flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
git commit -s
docs/development/architecture.rst
is up-to-date