Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FIX-#6072: unpin pyarrow and xfail test_read_parquet_pandas_index test #6223

Merged
merged 1 commit into from
May 31, 2023
Merged

FIX-#6072: unpin pyarrow and xfail test_read_parquet_pandas_index test #6223

merged 1 commit into from
May 31, 2023

Conversation

anmyachev
Copy link
Collaborator

@anmyachev anmyachev commented May 31, 2023 •
edited
Loading

What do these changes do?

  • first commit message and PR title follow format outlined here

    NOTE: If you edit the PR title to match this format, you need to add another commit (even if it's empty) or amend your last commit for the CI job that checks the PR title to pick up the new PR title.

  • passes flake8 modin/ asv_bench/benchmarks scripts/doc_checker.py
  • passes black --check modin/ asv_bench/benchmarks scripts/doc_checker.py
  • signed commit with git commit -s
  • Resolves BUG: test_read_parquet_pandas_index[pyarrow] is broken at main due to pyarrow 12.0 #6072
  • tests added and passing
  • module layout described at docs/development/architecture.rst is up-to-date

@anmyachev anmyachev marked this pull request as ready for review May 31, 2023 14:26
@anmyachev anmyachev requested a review from a team as a code owner May 31, 2023 14:26
YarShev
YarShev reviewed May 31, 2023
View reviewed changes
modin/pandas/test/test_io.py
and version.parse(pd.__version__) < version.parse("2.0.0")
and engine == "pyarrow"
):
pytest.xfail("incompatible versions; see #6072")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file an issue on unxfailing this test once we support pandas>=2.0.0.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please file an issue on unxfailing this test once we support pandas>=2.0.0.

Ok, but with pandas 2.0.0 it also doesn't work. I will look further

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, let's proceed the investigation as part of upgrading pandas or a separate issue.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

apache/arrow#35855

@YarShev YarShev merged commit f0f9ffe into modin-project:master May 31, 2023
@anmyachev anmyachev deleted the issue6072 branch May 31, 2023 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YarShev YarShev YarShev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BUG: test_read_parquet_pandas_index[pyarrow] is broken at main due to pyarrow 12.0
2 participants
@anmyachev @YarShev