Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add rename to registry.json #3276

Merged
merged 3 commits into from
Nov 19, 2023
Merged

Add rename to registry.json #3276

merged 3 commits into from
Nov 19, 2023

Conversation

Nicklaus-s
Copy link
Contributor

No description provided.

@Taaku18 Taaku18 changed the base branch from master to development July 10, 2023 10:55
@Taaku18 Taaku18 added plugin registry Request to be added into the plugin registry pending review labels Jul 10, 2023
StephenDaDev
StephenDaDev suggested changes Jul 11, 2023
View reviewed changes
Copy link
Member

@StephenDaDev StephenDaDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The command should be assigned a default permission level. This causes an error to be recorded every time. Not the end of the world, but it would be preferred if this was fixed.

The clock also does not remove itself if the command fails due to rate limits or a nonpermission-based reason creating the illusion to the user that the command is just being slow when it has actually failed.

@StephenDaDev
Copy link
Member

Also not sure what the icon is

@Nicklaus-s
Copy link
Contributor Author

I've added a permission group check, see line 16 & made sure to include a fallback exception, see line 40. I'm not exactly sure if this is what you were asking for, but I believe I've fixed everything.

I've also changed the attached icon.

@Nicklaus-s Nicklaus-s requested a review from StephenDaDev July 14, 2023 20:31
@Nicklaus-s
Copy link
Contributor Author

chat is it true this from april

@StephenDaDev
Copy link
Member

@Taaku18 Recommending for addition in next update

@StephenDaDev StephenDaDev reopened this Nov 5, 2023
@StephenDaDev
Copy link
Member

clicked the wrong button

Taaku18
Taaku18 approved these changes Nov 19, 2023
View reviewed changes
Copy link
Collaborator

@Taaku18 Taaku18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the addition, will be added to the registry in the next update.

@Taaku18 Taaku18 added staged Staged for next version and removed pending review labels Nov 19, 2023
@Taaku18 Taaku18 merged commit c6f87cd into modmail-dev:development Nov 19, 2023
2 checks passed
raidensakura pushed a commit to raidensakura/modmail that referenced this pull request Apr 10, 2024
@Nicklaus-s @raidensakura
Add rename to registry.json (modmail-dev#3276)
0b7401b 
* Add `rename` to `registry.json`

Signed-off-by: Nicklaus <[email protected]>

* Change icon

Signed-off-by: Nicklaus <[email protected]>

---------

Signed-off-by: Nicklaus <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StephenDaDev StephenDaDev StephenDaDev approved these changes

@Taaku18 Taaku18 Taaku18 approved these changes

Assignees
No one assigned
Labels
plugin registry Request to be added into the plugin registry staged Staged for next version
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Nicklaus-s @StephenDaDev @Taaku18