Remove Heroku Reference from Debug Command #3292
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Taaku18
requested changes
Jul 13, 2023
Taaku18
approved these changes
Jul 14, 2023
raidensakura
pushed a commit
to raidensakura/modmail
that referenced
this pull request
Apr 10, 2024
* Very few users are still using Heroku for hosting, so this comment could cause confusion. * Fix mistake --------- Co-authored-by: Taku <[email protected]>
khakers
pushed a commit
to khakers/OpenModmail
that referenced
this pull request
Jun 18, 2024
* Very few users are still using Heroku for hosting, so this comment could cause confusion. * Fix mistake --------- Co-authored-by: Taku <[email protected]> (cherry picked from commit d891ad1)
khakers
pushed a commit
to khakers/OpenModmail
that referenced
this pull request
Jun 18, 2024
* Very few users are still using Heroku for hosting, so this comment could cause confusion. * Fix mistake --------- Co-authored-by: Taku <[email protected]> (cherry picked from commit d891ad1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very few users are still using Heroku for hosting their instance of Modmail. As such, this comment could cause confusion in regard to where to find their logs. So, changing it to a general term, such as console, remedies this issue, and doesn't specifically target any one hosting method.