Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stdlib] Make StringSlice CollectionElement #3597

Closed
wants to merge 7 commits into from
Closed

[stdlib] Make StringSlice CollectionElement #3597

wants to merge 7 commits into from

Conversation

martinvuyk
Copy link
Contributor

Make StringSlice CollectionElement

@martinvuyk martinvuyk requested a review from a team as a code owner October 3, 2024 16:34
@soraros
Copy link
Contributor

soraros commented Oct 3, 2024 •
edited
Loading

Can we simply use @value (and/or register_passable) here?

@martinvuyk
Copy link
Contributor Author

martinvuyk commented Oct 3, 2024 •
edited
Loading

HI @soraros. I'm seeing that Span uses @value but it's components are just an UnsafePointer and an Int, so if we used @register_passable("trivial") here it would need to be changed as well. BTW I also still don't quite understand the difference between @register_passable("trivial") and plain @register_passable. WDYT?

@soraros
Copy link
Contributor

soraros commented Oct 3, 2024

@martinvuyk I'm not sure either. Let's wait for the team to respond.

This was referenced Oct 4, 2024
Open
Closed
@JoeLoser JoeLoser self-assigned this Oct 13, 2024
@martinvuyk
Copy link
Contributor Author

@JoeLoser fixed the merge conflict but the CI keeps failing on error: cannot open input file '/home/runner/work/mojo/mojo/stdlib/scripts/check-licenses.mojo for this and other PRs

@JoeLoser
Copy link
Collaborator

!sync

@modularbot modularbot added the imported-internally Signals that a given pull request has been imported internally. label Oct 14, 2024
@modularbot
Copy link
Collaborator

✅🟣 This contribution has been merged 🟣✅

Your pull request has been merged to the internal upstream Mojo sources. It will be reflected here in the Mojo repository on the nightly branch during the next Mojo nightly release, typically within the next 24-48 hours.

We use Copybara to merge external contributions, click here to learn more.

@modularbot modularbot added the merged-internally Indicates that this pull request has been merged internally label Oct 14, 2024
modularbot added a commit that referenced this pull request Oct 16, 2024
@modularbot @martinvuyk
[External] [stdlib] Make StringSlice CollectionElement (#49050)
c6f3b20 
[External] [stdlib] Make `StringSlice` `CollectionElement`

Make `StringSlice` `CollectionElement`

ORIGINAL_AUTHOR=martinvuyk
<[email protected]>
PUBLIC_PR_LINK=#3597

Co-authored-by: martinvuyk <[email protected]>
Closes #3597
MODULAR_ORIG_COMMIT_REV_ID: 4a6d29b9abbe111bd0c5dbf001e69d75729c6750
@modularbot modularbot added the merged-externally Merged externally in public mojo repo label Oct 16, 2024
@modularbot
Copy link
Collaborator

Landed in c6f3b20! Thank you for your contribution 🎉

@modularbot modularbot closed this Oct 16, 2024
@martinvuyk martinvuyk deleted the make-stringslice-collectionelement branch October 16, 2024 01:16
modularbot added a commit that referenced this pull request Dec 17, 2024
@modularbot @martinvuyk
[External] [stdlib] Make StringSlice CollectionElement (#49050)
b95eaba 
[External] [stdlib] Make `StringSlice` `CollectionElement`

Make `StringSlice` `CollectionElement`

ORIGINAL_AUTHOR=martinvuyk
<[email protected]>
PUBLIC_PR_LINK=#3597

Co-authored-by: martinvuyk <[email protected]>
Closes #3597
MODULAR_ORIG_COMMIT_REV_ID: 4a6d29b9abbe111bd0c5dbf001e69d75729c6750
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JoeLoser JoeLoser JoeLoser approved these changes

Assignees

@JoeLoser JoeLoser

Labels
imported-internally Signals that a given pull request has been imported internally. merged-externally Merged externally in public mojo repo merged-internally Indicates that this pull request has been merged internally
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@martinvuyk @soraros @JoeLoser @modularbot