-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add mojo-libc package #32
Conversation
Signed-off-by: Manuel Saelices <[email protected]>
Thanks for submitting, @msaelices! It looks like the |
Signed-off-by: Manuel Saelices <[email protected]>
Signed-off-by: Manuel Saelices <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Manuel Saelices <[email protected]>
I think you're using a wrong command: |
Signed-off-by: Manuel Saelices <[email protected]>
@msaelices do you mind trying @yetalit's suggestion of |
Signed-off-by: Manuel Saelices <[email protected]>
Sorry for being so late. Fixed! |
Thank you @msaelices! I assume this package isn't yet compatible with 24.6 yet, right? If so, do you mind specifying that in line 19 of your |
Done: 70522a7 |
Thank you @msaelices! We're getting an error now from the test file:
|
A quick update for everyone with open PRs that will hopefully make this process a bit easier: it's actually not necessary to include your test file(s) in the PR if you'd like to keep them in your source repo instead, as long as you include the test invocation and SHA/ID for your GitHub in the recipe file (here's an example with @TilliFe's Endia). Please let me know if you have any questions! |
Signed-off-by: Manuel Saelices <[email protected]>
Checklist
0
(for new packages, or if the version changed)