Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mojo-libc package #32

Merged
merged 22 commits into from
Jan 27, 2025
Merged

Add mojo-libc package #32

merged 22 commits into from
Jan 27, 2025

Conversation

msaelices
Copy link
Contributor

@msaelices msaelices commented Dec 12, 2024

Checklist

  • License file is packaged (see here for an example).
  • Set the build number to 0 (for new packages, or if the version changed)
  • Bumped the build number (if the version is unchanged)

@carolinefrasca
Copy link
Collaborator

Thanks for submitting, @msaelices! It looks like the recipe.yaml file lists https://github.com:msaelices/mojo-libc.git as the source rather than https://github.com/msaelices/mojo-libc.git - do you mind fixing?

Signed-off-by: Manuel Saelices <[email protected]>
Copy link

@crisadamo crisadamo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yetalit
Copy link
Contributor

yetalit commented Dec 16, 2024

I think you're using a wrong command: magic run mojo package libc -o ${PREFIX}/lib/mojo/libc.mojopkg
You're not also giving the correct path to the source code.
Use this instead: mojo package src/libc -o ${PREFIX}/lib/mojo/libc.mojopkg

Signed-off-by: Manuel Saelices <[email protected]>
@carolinefrasca
Copy link
Collaborator

@msaelices do you mind trying @yetalit's suggestion of mojo package src/libc -o ${PREFIX}/lib/mojo/libc.mojopkg for the build script? And then I can rerun the worfklows

@msaelices
Copy link
Contributor Author

mojo package src/libc -o ${PREFIX}/lib/mojo/libc.mojopkg

Sorry for being so late. Fixed!

carolinefrasca
carolinefrasca previously approved these changes Jan 9, 2025
@carolinefrasca
Copy link
Collaborator

Thank you @msaelices! I assume this package isn't yet compatible with 24.6 yet, right? If so, do you mind specifying that in line 19 of your recipe.yaml file via - max ==24.6?

@msaelices
Copy link
Contributor Author

Thank you @msaelices! I assume this package isn't yet compatible with 24.6 yet, right? If so, do you mind specifying that in line 19 of your recipe.yaml file via - max ==24.6?

Done: 70522a7

@carolinefrasca
Copy link
Collaborator

Thank you @msaelices! We're getting an error now from the test file:

 │ │ │ Testing commands:
 │ │ │ + mojo run test.mojo
 │ │ │ mojo: error: module does not define a `main` function
 │ │ │ × error Script failed with status 1
 │ │ │ × error Work directory: '/home/runner/work/modular-community/modular-community/output/bld/rattler-build_libc_1736882039/work/test/run/etc/conda/test-files/libc/0'
 │ │ │ × error To debug the build, run it manually in the work directory (execute the `./conda_build.sh` or `conda_build.bat` script)
 │ │ │
 │ │ ╰─────────────────── (took 4 seconds)
 │ │
 │ ╰─────────────────── (took 5 seconds)
 │
 ╰─────────────────── (took 17 seconds)
Error:   × failed to run test: Script failed

@carolinefrasca
Copy link
Collaborator

A quick update for everyone with open PRs that will hopefully make this process a bit easier: it's actually not necessary to include your test file(s) in the PR if you'd like to keep them in your source repo instead, as long as you include the test invocation and SHA/ID for your GitHub in the recipe file (here's an example with @TilliFe's Endia). Please let me know if you have any questions!

@carolinefrasca carolinefrasca merged commit 7d7d08b into modular:main Jan 27, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants