Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parameter to ms-respond() to render all rules with !important #146

Merged
merged 1 commit into from
Jan 24, 2018

Conversation

hansspiess
Copy link
Contributor

To use modularscale with utility classes in inuitcss they have to render with !important to follow the inuit specifity convention (keeping a "flat" specifity tree across elements and components but let single purpose utility classes trump everything else, intentionally).

This changes the signature of ms-respond() but does not break anything since the additional parameter can be omitted entirely.

@scottkellum
Copy link
Member

Thanks @hansspiess I’ll merge and version up tonight. I’ll probably leave this feature undocumented but this is well written and considerate code that I’m sure will solve specificity problems for a lot of people.

Also if I don’t close this by Sunday I have forgotten about it, please ping the thread.

@scottkellum scottkellum merged commit 29e87be into modularscale:3.x Jan 24, 2018
@scottkellum
Copy link
Member

Sorry for the delay, thank you for the PR!

@hansspiess hansspiess deleted the ms-respond-important branch July 4, 2018 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants