Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Port to 3.x] Fix Various Issues with Form Panel Validation and Field Display - Part 4, Template Panel #16122

Merged
merged 4 commits into from
Apr 20, 2022

Conversation

smg6511
Copy link
Collaborator

@smg6511 smg6511 commented Apr 6, 2022

NOTE: This is part 4 of 6 of a revised submission of #15887. This should be reviewed after part 2 is merged (there are two small changes needed from that PR to make the locked switch appear correctly).

What does it do?

Ports enhancements to the Template form panel from PR #15146 to 3.x (including subsequent fixes by others).
Changes include:

  1. Updated panel JS to make form layout consistent with the layout introduced in the current TV panel, and utilize new shared methods introduced in the main FormPanel via part 1 of this PR set (already merged).
  2. Added a secondary Media Source combo for the preview image, as the new layout makes the main Media Source combo available only when Is Static is ticked. For the purposes of this PR, the new combo mirrors the original (so when one changes, the other reflects that same change) — this is, in effect, the current behavior, but it may be worthwhile to consider having a fully-independent secondary Source setting in the future.
  3. A handful of minor lexicon updates.

Why is it needed?

Makes needed UI and consistency improvements to the Template panel.

How to test

  1. From your terminal app, run grunt build from within the _build/templates/default folder and clear your browser cache.
  2. Create and update a few Templates to verify behavior and appearance is as expected.

Related issue(s)/PR(s)

Partial port of #15146

@smg6511 smg6511 requested review from opengeek and Mark-H as code owners April 6, 2022 01:35
@cla-bot cla-bot bot added the cla-signed CLA confirmed for contributors to this PR. label Apr 6, 2022
@smg6511 smg6511 added the pr/review-needed Pull request requires review and testing. label Apr 6, 2022
@smg6511 smg6511 added this to the v3.0.1 milestone Apr 6, 2022
Jim Graham added 4 commits April 18, 2022 01:03
Added secondary source combo and made a few lexicon changes
Removed link to code field, as scrolling was not working properly.
@smg6511 smg6511 force-pushed the 3.x-port-pr-15146-rev-part-4 branch from 35a3fc8 to 3099aa8 Compare April 18, 2022 05:03
@opengeek opengeek merged commit ae82f20 into modxcms:3.x Apr 20, 2022
@smg6511 smg6511 deleted the 3.x-port-pr-15146-rev-part-4 branch July 19, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed CLA confirmed for contributors to this PR. pr/review-needed Pull request requires review and testing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants