Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provider Genius.com #27

Closed
deedy5 opened this issue Mar 8, 2024 · 6 comments
Closed

Add provider Genius.com #27

deedy5 opened this issue Mar 8, 2024 · 6 comments
Labels
enhancement New feature or request

Comments

@deedy5
Copy link
Contributor

deedy5 commented Mar 8, 2024

  1. request api for url
    https://genius.com/api/search/multi?per_page=5&q=macarena
    see artist_names, full_title, url
  2. parse url
    https://genius.com/Los-del-rio-macarena-lyrics
@moehmeni moehmeni added the enhancement New feature or request label Mar 14, 2024
@moehmeni
Copy link
Owner

moehmeni commented Mar 15, 2024

Thanks for the suggestion.
It works on my machine [1] but fails the tests when querying step 1. I tested with both requests and curl_cffi. Logs showed it gets 403 status code for step 1.

[1] https://github.com/moehmeni/syncedlyrics/blob/main/syncedlyrics/providers/genius.py

@deedy5
Copy link
Contributor Author

deedy5 commented Mar 15, 2024

Try with curl-cffi, but use impersonate
self.session = requests.Session(impersonate="chrome")

@moehmeni
Copy link
Owner

If I use curl-cffi, I get an error mentioned in #29 in local. Also, the workflow test (with impersonate) could not pass as well.

@deedy5
Copy link
Contributor Author

deedy5 commented Mar 15, 2024

curl_cffi.requests.errors.RequestsError: Failed to perform, curl: (55) Recv failure: Connection reset by peer. See https://curl.se/libcurl/c/libcurl-errors.html first for more details.

look https://curl.se/libcurl/c/libcurl-errors.html

CURLE_SEND_ERROR (55)

Failed sending network data. 

def get_lrc()
Unclear problem. Are you sure a cookie is needed here?
Try to add logging before each line that returns None to see what happens.

moehmeni added a commit that referenced this issue Mar 16, 2024
@moehmeni
Copy link
Owner

I commented out the tests for Genius for now, but in action, can you please confirm it works with -p Genius?

@deedy5
Copy link
Contributor Author

deedy5 commented Mar 20, 2024

  1. megalobiz.com site's not working anymore, it says :megalobiz.com has expired,
  2. genius tests work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants