-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Per key/layer RGB underglow for 24.12 #36
base: zmk-update
Are you sure you want to change the base?
Conversation
…zation I tried using event instead of the 25ms underglow_tick to update the underglow on layer change only. That didn't improve the battery life much.... The second change is cutting off the led strip power if the underglow is not defined for a layer. Power is restored if a layer with rgb is activated, and cut off as soon as the layer is disabled. This, on the other hand, improves the battery life a lot, especially if you don't use rgb on your base layer. If you are using rgb on your base layer, setting CONFIG_ZMK_RGB_UNDERGLOW_AUTO_OFF_IDLE is highly recommended.
Thanks for your work on this. I tried your PR and everything seem to work with the Glorious Engrammer v40. I enjoy finally being able to set RGB values individually. |
In preparation for the re-do of zmkfirmware#2036 events that are useful for displays/indicators on the peripheral should be compiled on both sides so they can be raised on both sides
I tested using the Glove80 Layout Editor and was it worked for me! My layout can be seen here: https://dev.glove80.com/#/layout/user/6de3c382-9ced-4de8-a1a4-368b26e09d3f Is this a feature that will make it into ZMK or Glove80 main or will it will it likely stay as a PR? |
My plan is to open a similar PR on ZMK, and see if I can work on getting it merged. |
The latest update introduces some breaking changes:
|
49fbc27
to
15505c8
Compare
I used the latest This is my Layout: https://dev.glove80.com/#/layout/user/c458ddd6-cac3-4269-a578-a1d9cd506e94 |
Did anybody try to enable HID_POINTING and EXPERIMENTAL_RGB_LAYER on Engrammer v40 with this FW? RGB works for me but for some reason mouse is not. I did factory reset. |
This adds per key / per layer RGB underglow configuration on top of 24.12.
It's mainly based on @valdur mod with additional changes to make it configurable via devicetree.
This supersedes #30.
It includes:
How to use:
More instructions are available on my config repo.
TLDR: Add and customize this snippet to the Custom Device-tree field in the layout editor:
______
means the RGB is off. You can use predefined color name or RGB hex code like0xFF0000
for red.Full example on the Layout Editor here
To preserve battery life, I recommend enabling the
ZMK_RGB_UNDERGLOW_AUTO_OFF_IDLE
KConfig to automatically turn off underglow afterZMK_IDLE_TIMEOUT
ms (default to 30 seconds).From my limited experience, you can expect around one week of battery life with no RGB on the base layer.