Update docker setup #48
Conversation
| @@ -1,17 +1,11 @@ | |||
| up: | |||
| up: build | |||
There was a problem hiding this comment.
Why is build included here?
There was a problem hiding this comment.
I've included build so that make up will always launch the latest version of the code. It might be confusing if someone does a git pull and make up but the container does not get updated
| @@ -1,8 +1,12 @@ | |||
| FROM moexmen/node:8 | |||
There was a problem hiding this comment.
Do we need to use any functionality specific to moexmen/node?
There was a problem hiding this comment.
not really, any node 8 will do
There was a problem hiding this comment.
Nope, but moexmen/node has some standardization across all the docker images that we are using. Such as timezone configuration and a WORKDIR setting.
Coming to think of it, I'll make a change to copy the files to the /app folder instead.
There was a problem hiding this comment.
oh I didn't now the name of the folder mattered.
There was a problem hiding this comment.
It didn't, but it's more of a standardization. So we know that if we enter a container built by us, we know that /app folder will continue the application code.
There was a problem hiding this comment.
What do you think about using the base directory instead of /app? It seems clearer and more obvious to me.
There was a problem hiding this comment.
What do you mean by base directory?
There was a problem hiding this comment.
The first directory you see when you enter the container.
There was a problem hiding this comment.
Ah yes. ADD . . will work because the WORKDIR is specified in the base image.
soedar
force-pushed
the
update-dockerize
branch
from
691aff2 to
0f752d1
Compare
README.md
Outdated
| 1. Clone this repository | ||
| 1. Copy sample env file `cp .env.example .env` | ||
| 1. Modify the env file with secrets `$EDITOR .env` | ||
| 1. Build image `make build` |
There was a problem hiding this comment.
If build is included in up, we don't need this step.
soedar
force-pushed
the
update-dockerize
branch
from
0f752d1 to
78a7731
Compare
soedar
force-pushed
the
update-dockerize
branch
from
78a7731 to
c302a5f
Compare
I've made some changes to the Docker setup.
.envfile to store per deployment configurationENTRYPOINTinstead ofCMD(See Node v5.x.x does not exit on Ctrl-C in Docker container nodejs/node#4182)I've also updated the README.md file, and remove old files that are not necessary