email,url,ip format are now recognized #3
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohsen1
added a commit
that referenced
this pull request
Nov 18, 2015
email,url,ip format are now recognized
|
👍 perfect! |
|
@mohsen1 Are you using any linter for this project(to get space after attribute name etc or it is just the convention and i'm ignorant ? |
|
So you are using eslint for this project(json-to-json-schema) ? |
|
My editors picks up the eslintrc file automatically but you're right, it can be a pre step in the build script. |
|
What code editor you're using, i'm using sublime text :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i've deleted my old forked repo, created a new one and applied all the required changes (because i had some problems with rebasing so i said why not building it again from the scratch :) )