Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Working Group Notice Board Structure #304

Merged
merged 7 commits into from
Mar 27, 2022

Conversation

Sukriti-sood
Copy link
Contributor

@Sukriti-sood Sukriti-sood commented Mar 5, 2022

Signed-off-by: Sukriti-sood [email protected]

Pull Request Template

Description

Added Working Group Notice Board on Community Section of community-website

Type of change

  • New feature (non-breaking change which adds functionality).

Checklist:

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have made corresponding changes to the documentation.
  • I have added corresponding tests.
  • Any dependent changes have been merged and published in downstream modules.
  • I have signed the commit message to agree to Developer Certificate of Origin (DCO) (to certify that you wrote or otherwise have the right to submit your contribution to the project.) by adding "--signoff" to my git commit command.

ezgif com-gif-maker (2)

@Chicken-Biryani @HarshCasper

@gitpod-io
Copy link

gitpod-io bot commented Mar 5, 2022

@vercel
Copy link

vercel bot commented Mar 5, 2022

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/moja-global/contributor-website-v2/9e6NXka6cVmQWKQdG6V14BbseSgE
✅ Preview: https://contributor-website-v2-git-fork-sukriti-sood-35edb1-moja-global.vercel.app

@github-actions
Copy link

github-actions bot commented Mar 5, 2022

Running Lighthouse audit...

@shloka-gupta
Copy link
Member

@Sukriti-sood thank you! A good movie is to add screenshots/videos in the PR.

@YashKandalkar @SanjaySinghRajpoot @sohamsshah we decided on the design-- Sukriti has implemented-- during the UI working group meeting. Can you please have a look as well?

@SanjaySinghRajpoot
Copy link
Contributor

Looks good to me.

Copy link
Contributor

@YashKandalkar YashKandalkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTGM!

@shloka-gupta
Copy link
Member

shloka-gupta commented Mar 6, 2022

@Sukriti-sood @SanjaySinghRajpoot @YashKandalkar a question tho.

How do you think we should manage the meeting notes? It can go date wise and linked. But once linked... Where will the link lead to?

Will all the meeting notes be on one page?

Copy link
Member

@HarshCasper HarshCasper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few observations:

  • Why do we have so many docs for working groups that have not even started right now?
  • I'm not sure why do we have empty docs right here. The content should be imported from About_moja_global before we merge them.
  • Why do we have Agenda and Meeting notes on the community website? Aren't they already being published on About_moja_global? Why do we need to duplicate the content?
  • I'm not sure about the position of working groups in the sidebar.

The PR is not in a state to merge until the above comments are addressed.

@shloka-gupta
Copy link
Member

Hi, @HarshCasper

The notes are in About moja Global repo temporarily.

The idea was to be ready with the content and layout together so that we develop things faster. Once the layout's ready... The contents will be shifted. And deleted from About moja global.

I do agree. Maybe we should keep the working groups limited to the ones that are currently active.

We agreed on the sidebar in yesterday's meet. We would be happy to hear your advice on how can we improve?

@HarshCasper
Copy link
Member

HarshCasper commented Mar 6, 2022

@Chicken-Biryani

It doesn't make sense to me. We are refactoring About_moja_global to host content that is dynamically changing, like meeting notes, progress and more. Using it for Community Website defeats that purpose. If they were supposed to be deleted in future, why pollute the Git logs as well and not use Google Docs/HackMD for this?

At best, we can just link meeting notes, agenda and more to About_moja_global and rather keep the Community Website as an official word about the working groups. Even the primary sources, you are taking inspiration from, does not host meeting notes on an official website.

Coming to Sidebar, the first focus is on getting folks started up and letting them know how to contribute. The working groups should follow later.

@shloka-gupta
Copy link
Member

@HarshCasper you're right. My bad... It was my idea to shift things. Thanks for reflecting!

@Sukriti-sood can you do the following:

(@HarshCasper do correct me if I am wrong anywhere)

  • We're just going to add the About section to the community website. So We can let go the meeting notes and Agenda.

  • Shift the 'working-groups' below the contribution section.

  • Remove the working groups that aren't active. i.e keep UI and Documentation working group.

  • Take the content of About-UI from the working groups folder and About- Documentation from Harsh.

@HarshCasper if there are more required changes or changes please do add them.

@Sukriti-sood
Copy link
Contributor Author

@Chicken-Biryani I will update the pr with mentioned changes.

@Sukriti-sood
Copy link
Contributor Author

Sukriti-sood commented Mar 9, 2022

@Chicken-Biryani @HarshCasper Should the any-Working group section include links to Agenda and Meeting Notes?

@shloka-gupta
Copy link
Member

Hi @Sukriti-sood can you please put a video with the updates!

Thanks.

@Sukriti-sood
Copy link
Contributor Author

ezgif com-gif-maker (3)

As discuused in the last ui-wg meeting, Arpita will add UI-wg documentaton, I have not added.

@shloka-gupta
Copy link
Member

@Sukriti-sood I think Arpita can take up that task for another upcoming working group?

Can you please add info for the UI working group as well. 😅

@Sukriti-sood
Copy link
Contributor Author

@Sukriti-sood I think Arpita can take up that task for another upcoming working group?

Can you please add info for the UI working group as well. 😅

Ya, sure 👍🏻

Signed-off-by: Sukriti-sood <[email protected]>
Signed-off-by: Sukriti-sood <[email protected]>
Signed-off-by: Sukriti-sood <[email protected]>
Signed-off-by: Sukriti-sood <[email protected]>
Signed-off-by: Sukriti-sood <[email protected]>
@Sukriti-sood
Copy link
Contributor Author

ezgif com-gif-maker (4)

@shloka-gupta
Copy link
Member

Thank you so much, @Sukriti-sood!

@sohamsshah and @HarshCasper do share your opinions.

title: Documentation Working Group
---

![Active Working Group](https://img.shields.io/badge/STATUS-ACTIVE-green?style=for-the-badge)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we refactor this to use sort of a React component, like: <Working status="active"></Working>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will update this.


All the Contributors for the Documentation Working Group are invited to a bi-weekly sync call where we discuss the work that has been completed and the upcoming documentation work that needs to be done.

To get started, please fill this form: **[https://forms.gle/ibH2XsaBSAeiyQcX7](https://forms.gle/ibH2XsaBSAeiyQcX7)**
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can possibly remove this form. Its unmonitored right now.

Comment on lines 68 to 70
Once you fill the form, you will hear back from one of the coordinators to help you get started in an smooth manner. You will receive invites for our sync call and will be added to the Slack Channels and GitHub teams where the work can be further coordinated.

We are looking forward to your contributions!
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this part

@aornugent
Copy link

Nice work @Sukriti-sood!

Can we please add the working groups to the Getting Started section of 'Know the community' and the footer of the main page? Maybe even the top level of the side bar, under Projects and above Blogs.

@Sukriti-sood
Copy link
Contributor Author

Sukriti-sood commented Mar 16, 2022

@aornugent I have added link in footer and know the community Section. As of now, it is directed to documentation working group section but later we can link it to What are working Groups Section (Still not added). At the moment, I do not think it is a good idea to add working-groups section to sidebar since our navigation bar already has several sections.

@aornugent
Copy link

@Sukriti-sood - are you ready to merge? 🤞

@Sukriti-sood
Copy link
Contributor Author

@Sukriti-sood - are you ready to merge? crossed_fingers

Yes, If no changes required 😅

@aornugent aornugent merged commit cb6447f into moja-global:main Mar 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants