Fixes #48 rootlocation does not correctly work #92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- maven is executed on a submodule - projects aggregation root and parent is not the same - child modules may reside in deeper nested folders without a pom.xml in between
This was referenced Jun 2, 2020
pzygielo
reviewed
Jun 12, 2020
| * Returns a set of all child modules for a project, including any defined in profiles (ignoring profile activation). | ||
| * | ||
| * @param project The project. | ||
| * @param logger The logger to use. |
There was a problem hiding this comment.
No such parameter logger.
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48
this is a replacement/improvement of PR #84 that also takes special cases into account: