Handle usize
overflow on big cache capacity
#28
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue #25,
usize
multiply overflow on big cache capacity.Changes
max_capacity * 32
) when setting the capacity of the popularity estimatorFrequencySketch
.128u32..=u32::MAX
.usize
tou32
so that the estimator will work consistency on any platform with different pointer width.Verification
sync::base_cache
andunsync::cache
modules to ensure overflows should not happen and sizes of the population estimators are correct:Fixes #25