Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add default reqTimeout #312

Merged
merged 1 commit into from
Jul 28, 2022
Merged

add default reqTimeout #312

merged 1 commit into from
Jul 28, 2022

Conversation

AndreMaz
Copy link
Member

Fixes #206

In node.js versions < v18 this was set to 0 (meaning disabled).

However, in the docs it is stated that:

It must be set to a non-zero value (e.g. 120 seconds) to protect against potential Denial-of-Service attacks in case the server is deployed without a reverse proxy in front.

In node.js v18 the default value is 300000 ms = 5 minutes,

This PR uses node.js v18 default value

@intech
Copy link
Member

intech commented Jul 14, 2022

@AndreMaz Thanks so much!

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@icebob icebob merged commit 5b0eebe into master Jul 28, 2022
@icebob icebob deleted the reqTimeout branch July 28, 2022 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants