Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of lodash.isObject. #755

Merged
merged 1 commit into from
May 23, 2020

Conversation

abdavid
Copy link

@abdavid abdavid commented May 23, 2020

📝 Description

Remove usage of lodash.isObject.
Introduce utility function isObject

🎯 Relevant issues

Related #433
Fixes #739

💎 Type of change

  • Chore (non-breaking change. Quality of Life changes)

🚦 How Has This Been Tested?

Added test to changes.

🏁 Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas

@abdavid abdavid changed the title Remove usage of lodash.isObject. Added equivalent to utils. Updated t… Remove usage of lodash.isObject. May 23, 2020
@coveralls
Copy link

coveralls commented May 23, 2020

Pull Request Test Coverage Report for Build 2441

  • 50 of 50 (100.0%) changed or added relevant lines in 20 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.01%) to 91.957%

Totals Coverage Status
Change from base Build 2440: 0.01%
Covered Lines: 7261
Relevant Lines: 7611

💛 - Coveralls

Copy link
Member

@icebob icebob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, thank you!

@icebob icebob merged commit 5191beb into moleculerjs:master May 23, 2020
@abdavid abdavid deleted the chore/lodash-isObject branch May 23, 2020 10:22
@Wallacy
Copy link
Contributor

Wallacy commented May 27, 2020

@abdavid I did a little changed on you method because did not handle object-wrapped strings;

Thinking about your solution to use Object.prototype.toString ; If thered no precedence on Moleculer to check array and objects together i think may be a worthwhile;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[lodash] Remove usage of _.isObject
4 participants