Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

chore: Add Dockerfile and publish workflow #1

Merged
merged 14 commits into from
Apr 28, 2022

Conversation

poppoerika
Copy link
Collaborator

@poppoerika poppoerika commented Apr 27, 2022

momento-proxy Docker image is tested on an EC2 instance and I was able to set a key/value pair.

[root@ip-172-31-53-115 bin]# telnet 0.0.0.0 11211
Trying 0.0.0.0...
Connected to 0.0.0.0.
Escape character is '^]'.
set erika 0 0 3
eri 
STORED

Every time a pr is merged to main, a new Docker image is built and pushed to the gomomento/momento-proxy repo.
When users run docker run, they need to provide an env variable MOMENTO_AUTHENTICATION (Momento auth token).
Also updated momento-proxy.md to include how to run the momento-proxy Docker image.

… pushing image with latest tag step to publish workflow
Copy link
Member

@eaddingtonwhite eaddingtonwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@poppoerika This is looking good to me nice work! Lets get it merged and can do final verification again in our main momento branch make sure image gets published properly. Then can work to get contribute branch down into Bryan's fork.

Maybe have @danielamiao take one more pass on content quick just to get one more pair eyes.

@poppoerika
Copy link
Collaborator Author

@eaddingtonwhite @danielamiao
Updated the Dockerfile a bit so that we can mount a host machine's config directory to a container's config directory to be able to use a custom config file passed by users.
Also updated README to reflect this change.
Tested it on an EC2 instance and was able to use my custom config file to run.

Copy link
Member

@eaddingtonwhite eaddingtonwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @poppoerika

@poppoerika poppoerika merged commit abd38e7 into momento Apr 28, 2022
@danielamiao danielamiao deleted the chore/dockerizeMomentoProxyBinary branch April 28, 2022 22:34
eaddingtonwhite pushed a commit that referenced this pull request Dec 29, 2022
Update readme and manifest to reflect new fork
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants