Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby 3.3.4 #727

Merged
merged 9 commits into from
Jul 27, 2024
Merged

Ruby 3.3.4 #727

merged 9 commits into from
Jul 27, 2024

Conversation

yonta
Copy link
Collaborator

@yonta yonta commented Jun 14, 2024

もうRuby 3.3.3 3.3.4が出ている!

  • Ruby 3.3.4にした
  • bundle updateをした
  • bundler自体もアップデートした

@github-actions github-actions bot requested a review from momocus June 14, 2024 07:55
Copy link

github-actions bot commented Jun 14, 2024

📦 esbuild Bundle Analysis for sakazuki

This analysis was generated by esbuild-bundle-analyzer. 🤖

Meta File Out File Size (raw) Note
meta.json app/assets/builds/application.js 1.01 MB 🆕 Added
Largest paths These visualization shows top 20 largest paths in the bundle.

Meta file: meta.json, Out file: app/assets/builds/application.js

Path Size
node_modules/chart.js/dist ${{\color{Goldenrod}{ ██████▊ }}}$ 27.4%, 273.88 KB
app/javascript/completion ${{\color{Goldenrod}{ ████▎ }}}$ 17.1%, 170.75 KB
node_modules/@hotwired/turbo ${{\color{Goldenrod}{ ███▎ }}}$ 13.2%, 131.96 KB
node_modules/bootstrap/dist ${{\color{Goldenrod}{ ███ }}}$ 12.4%, 124.34 KB
node_modules/simplelightbox/dist ${{\color{Goldenrod}{ ██▏ }}}$ 8.8%, 87.73 KB
node_modules/@hotwired/stimulus ${{\color{Goldenrod}{ ██ }}}$ 8.4%, 84.29 KB
node_modules/@popperjs/core ${{\color{Goldenrod}{ █▍ }}}$ 5.6%, 55.66 KB
node_modules/@rails/actioncable ${{\color{Goldenrod}{ ▌ }}}$ 2.0%, 19.51 KB
node_modules/rater-js/index.js ${{\color{Goldenrod}{ ▍ }}}$ 1.6%, 16.42 KB
node_modules/@kurkle/color ${{\color{Goldenrod}{ ▎ }}}$ 1.3%, 13.37 KB
app/javascript/taste_graph ${{\color{Goldenrod}{ ▏ }}}$ 0.8%, 7.56 KB
app/javascript/controllers ${{\color{Goldenrod}{ ▏ }}}$ 0.7%, 7.12 KB
node_modules/@hotwired/turbo-rails ${{\color{Goldenrod}{ }}}$ 0.4%, 3.82 KB
node_modules/ts-deepmerge/esm ${{\color{Goldenrod}{ }}}$ 0.2%, 1.69 KB
node_modules/just-zip-it/index.mjs ${{\color{Goldenrod}{ }}}$ 0.1%, 785 B
node_modules/chart.js/helpers ${{\color{Goldenrod}{ }}}$ 0.0%, 0 B
app/javascript/application.js ${{\color{Goldenrod}{ }}}$ 0.0%, 0 B
Details

Next to the size is how much the size has increased or decreased compared with the base branch of this PR.

  • ‼️: Size increased by 20% or more. Special attention should be given to this.
  • ⚠️: Size increased in acceptable range (lower than 20%).
  • ✅: No change or even downsized.
  • 🗑️: The out file is deleted: not found in base branch.
  • 🆕: The out file is newly found: will be added to base branch.

@yonta yonta removed the request for review from momocus June 14, 2024 07:55
@yonta
Copy link
Collaborator Author

yonta commented Jun 14, 2024

ん-??
bunlde installがActionsのときだけ失敗している

@yonta
Copy link
Collaborator Author

yonta commented Jun 14, 2024

3.3.3で同じ問題に遭遇している人がいるようだ。
net-popかRuby本体か、メンテナが調査中。

ruby/net-pop#26

@yonta yonta marked this pull request as draft June 14, 2024 09:02
@yonta yonta mentioned this pull request Jun 14, 2024
@yonta
Copy link
Collaborator Author

yonta commented Jun 18, 2024

Ruby側でパッチが入った。3.3.4で治るのかな

@yonta yonta force-pushed the pr/ruby3.3.3 branch 2 times, most recently from 3e8cadc to 7cebdfa Compare June 19, 2024 06:34
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.57%. Comparing base (37fe2c8) to head (7cebdfa).
Report is 28 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #727   +/-   ##
=======================================
  Coverage   96.57%   96.57%           
=======================================
  Files          17       17           
  Lines         321      321           
=======================================
  Hits          310      310           
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@yonta
Copy link
Collaborator Author

yonta commented Jun 19, 2024

これで治るってあるけど、これいれるかどうするかは悩むわね。
現状、コミットに入れてみたら、やはりCIは通るようになった。

# Needed until Ruby 3.3.4 is released https://github.com/ruby/ruby/pull/11006
gem 'net-pop', github: 'ruby/net-pop'

@yonta
Copy link
Collaborator Author

yonta commented Jun 30, 2024

Ruby3.3.4まで待つことにしよう。
Railsのバージョンアップは先にやってしまおう。

@yonta
Copy link
Collaborator Author

yonta commented Jul 14, 2024

Ruby 3.3.4で修正された!いけるぞ!

@yonta yonta marked this pull request as ready for review July 16, 2024 15:44
@yonta yonta requested a review from momocus July 16, 2024 15:44
@yonta yonta changed the title Ruby 3.3.3 Ruby 3.3.4 Jul 16, 2024
@momocus momocus merged commit c99a04b into main Jul 27, 2024
5 checks passed
@momocus momocus deleted the pr/ruby3.3.3 branch July 27, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants