Feat/romka/fix build #7
Conversation
| "exclude": ["dist"], | ||
| "include": ["lib"] | ||
| "exclude": ["dist", "node_modules"], | ||
| "include": ["./lib/**/*"] |
There was a problem hiding this comment.
what's the difference between ["lib"] and ["./lib/**/*"] ?
There was a problem hiding this comment.
["lib"] includes files only at the top level of the lib directory, while ["./lib/**/*"] includes all files in lib and its subdirectories, providing a more extensive match for projects that organize code into nested directories within lib.
thats what chat told me when i asked him that couple of days ago
There was a problem hiding this comment.
I'm pretty sure it will include everything
| // Determine if we are in a production environment | ||
| // const production = !process.env.ROLLUP_WATCH; |
There was a problem hiding this comment.
do we need still this comment?
packages/api/package.json
Outdated
| ] | ||
| ], | ||
| "devDependencies": { | ||
| "@graphql-codegen/typescript-operations": "^4.1.2", |
There was a problem hiding this comment.
why do we need this dependency?
|
|
||
| constructor(token: string, apiVersion = defaultVersion) { | ||
| constructor(token: string, apiVersion: AvailableVersions | string = defaultVersion) { |
There was a problem hiding this comment.
why not?
| constructor(token: string, apiVersion: AvailableVersions | string = defaultVersion) { | |
| constructor(token: string, apiVersion: AvailableVersions = defaultVersion) { |
There was a problem hiding this comment.
its in done that way so users can give custom and not only current, if dont want it to change automatically and also so we dont need to maintain the const...
There was a problem hiding this comment.
IMO we should not allow users to provide any string they want
There was a problem hiding this comment.
It won’t matter since it’s then used only for version. If we are talking security wise, if they give bad string it’ll give them an error (or a bad version)
So it’s either give them string they want to get the version they specifically want to be, or to actively update the const of versions
We should talk about this
fix build
fix types
add new generated files