feat(Modal): keep focus inside opened modal, return focus to last element #2434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
talkor
approved these changes
Sep 24, 2024
| /> | ||
| {children} | ||
| </div> | ||
| <FocusLock returnFocus> |
There was a problem hiding this comment.
We need to use it also in Dialogs in the future
There was a problem hiding this comment.
yep, we need to maybe implement it in all the system modals and old modal, and therefore all the locks would use the same lib and can live in harmony, until all would migrate to the new modal
| @@ -129,6 +129,71 @@ describe("Modal", () => { | |||
| expect(mockOnClose).toHaveBeenCalled(); | |||
| }); | |||
|
|
|||
| it("traps focus inside the modal when opened", () => { | |||
YossiSaadi
force-pushed
the
feat/yossi/modal-a11y-lock-scroll-of-parts-other-than-modal-when-opened-7391259531
branch
2 times, most recently
from
6306ce0 to
26df930
Compare
Base automatically changed from
feat/yossi/modal-a11y-lock-scroll-of-parts-other-than-modal-when-opened-7391259531
to
feat/yossi/new-modal-building-blocks-7359960492
September 25, 2024 07:46
An error occurred while trying to automatically change base from
feat/yossi/modal-a11y-lock-scroll-of-parts-other-than-modal-when-opened-7391259531
to
feat/yossi/new-modal-building-blocks-7359960492
September 25, 2024 07:46
YossiSaadi
force-pushed
the
feat/yossi/modal-a11y-keep-focus-only-inside-modal-7360933300
branch
from
16dc805 to
c56818d
Compare
YossiSaadi
merged commit 5f66d89
into
feat/yossi/new-modal-building-blocks-7359960492
9 of 10 checks passed
YossiSaadi
deleted the
feat/yossi/modal-a11y-keep-focus-only-inside-modal-7360933300
branch
YossiSaadi
added a commit
that referenced
this pull request
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Focus lock
Focus should be locked inside Modal and to not let "Tab" click to focus stuff outside of the Modal
https://monday.monday.com/boards/3532714909/pulses/7360933300
Focus should return to last element that was opened before modal opened
https://monday.monday.com/boards/3532715121/pulses/7391253003